Skip to content

AvoidLongLines: Make internal function DiagnosticSeverity private#1851

Merged
bergmeister merged 1 commit intomasterfrom
AvoidLongLines-CodeCleanup
Oct 31, 2022
Merged

AvoidLongLines: Make internal function DiagnosticSeverity private#1851
bergmeister merged 1 commit intomasterfrom
AvoidLongLines-CodeCleanup

Conversation

@bergmeister
Copy link
Collaborator

PR Summary

Code analysis showed that this function is only used by the rule itself, therefore it shouldn't have been public. No change of behavior. Technically breaking but this method was never intended to be public and other rules do not have public methods to return the DiagnosticSeverity they will emit, in fact depending on the analysis they might be different.

PR Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants