Make Invoke-Formatter test case assertion fail in case of incorrect casing#1888
Merged
bergmeister merged 1 commit intoPowerShell:masterfrom Feb 10, 2023
alexandear:test-fix-fmt-case
Merged
Make Invoke-Formatter test case assertion fail in case of incorrect casing#1888bergmeister merged 1 commit intoPowerShell:masterfrom alexandear:test-fix-fmt-case
bergmeister merged 1 commit intoPowerShell:masterfrom
alexandear:test-fix-fmt-case
Conversation
bergmeister
approved these changes
Feb 10, 2023
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
thanks for helping us catch this as well. You are totally right.
cc @kilasuit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes the test
"corrects case of of cmdlet inside interpolated string"forInvoke-Formatter. It follows #1885 which didn't fully fixed the test.Additional Info
The idea is to use
-BeExactlyfor case-sensitive strings comparison.With changes in the PR the test fails when the expected string is
'"$(get-childItem)"':PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.