Do not print summary repeatedly for each logger#2058
Merged
andyleejordan merged 1 commit intoPowerShell:mainfrom Feb 20, 2025
Merged
Do not print summary repeatedly for each logger#2058andyleejordan merged 1 commit intoPowerShell:mainfrom
andyleejordan merged 1 commit intoPowerShell:mainfrom
Conversation
bergmeister
approved these changes
Feb 17, 2025
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Thanks, ran CI, looks good. Thoughts @andyleejordan ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates the
foreachloop where diagnostics are written to only write the summary once instead of once per logger. Given that the summary is always printed to the host (and not to the logger), it does not make sense to print it multiple times. Since there's only a single logger shipped with PSScriptAnalyzer, this does manifest in practice, but it's relevant for my follow-up PRs. :)PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.