Invoke-ScriptAnalyzer: Print summary only once per invocation#2063
Merged
andyleejordan merged 1 commit intoPowerShell:mainfrom Feb 28, 2025
Merged
Invoke-ScriptAnalyzer: Print summary only once per invocation#2063andyleejordan merged 1 commit intoPowerShell:mainfrom
andyleejordan merged 1 commit intoPowerShell:mainfrom
Conversation
MatejKafka
requested review from
andyleejordan and
bergmeister
as code owners
andyleejordan
force-pushed
the
single-summary-pipeline
branch
from
ed43569 to
cc57fa5
Compare
andyleejordan
approved these changes
Feb 25, 2025
Member
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
Looks like a good refactor to me, thanks! Gotta love dictionaries.
MatejKafka
force-pushed
the
single-summary-pipeline
branch
from
cc57fa5 to
55d50d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Similarly to the previous
-EnableExitPR, this PR moves the summary printed when-ReportSummaryis passed toEndProcessing, so that it's only printed once, instead of once for every value from the pipeline.Imo, users are likely to be interested in the summary from all of the piped files, not for each file separately. Since the message is printed to the host (so the caller has no easy way to capture it), I don't believe moving it to be a breaking change.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.