SyncplayServer does not run with room permanence enabled

[haz429]

Describe the bug
I have tried to start a private server with the new "room permanence" option, but when trying to run the server, the window would close immediately after opening and briefly show an error message (below). I've had no problems running a private server without this option, and the only thing I can assume is that it's just broken.

To Reproduce
Steps to reproduce the behavior:

1. Run the server with --rooms-db-file [file] option, for example:
   "C:\Program Files (x86)\Syncplay\syncplayServer.exe" --password X --salt Y --port Z --rooms-db-file [anything] --permanent-rooms-file [something else]
   I am not 100% sure what the last two parameters are meant to be, but I tried multiple different things (full path, .db file & .txt file, files with no extension)
2. Server window opens and immediately closes, showing an error message for a very brief amount of time.

Expected behavior
For the server to start with room permanence enabled.

Screenshots

Version and platform:

• OS: Windows 10 64-bit
• Syncplay version and build type: Syncplay 1.7.0 Beta 1
• Media player and version: n/a

Additional context
n/a

[Et0h]

Thanks for reporting this. It looks like I'll need to (a) add sqlite3 to what is bundled with the Syncplay server by py2exe and (b) update the instructions at https://syncplay.pl/guide/server/

[Et0h]

@haz429 Please try the Windows portable development build from https://github.com/Syncplay/syncplay/suites/6312710765/artifacts/226583972 and let me know if that works.

If you want persistent rooms then all you need is --rooms-db-file which specifies a path for Syncplay to use to store the database file. However, if you want it to have rooms which are always listed even when they have no files in the playlist then you also have to specify a .txt file as permanent-rooms-file with one room per line using --permanent-rooms-file.

Instructions on the command line switches from the docs:

--rooms-db-file [file]
Enables room persistence. Path is to where a database file should be loaded/create where room data will be written to and read from. This will enable rooms to persist without watchers and through restarts. Will not work if using --isolate-rooms.

--permanent-rooms-file [file]
Specifies a list of rooms that will still be listed even if their playlist is empty. Path is to where a text file with one room per line. This will require persistent rooms to be enabled.

[haz429]

Thanks for the instructions, can confirm that room permanence works on the development build. One thing I have run into is that any rooms named in the --permanent-rooms-file text file will be created upon server launch, but will disappear if a user leaves that respective room (with or without files in the playlist). Shouldn't affect me personally but I don't think it's working as intended.

[Et0h]

Thanks for the instructions, can confirm that room permanence works on the development build.

Great!

One thing I have run into is that any rooms named in the --permanent-rooms-file text file will be created upon server launch, but will disappear if a user leaves that respective room (with or without files in the playlist). Shouldn't affect me personally but I don't think it's working as intended.

Yeah that's something which wants fixing. Thanks for the report. I'll leave this issue open until it's been resolved.

[Et0h]

One thing I have run into is that any rooms named in the --permanent-rooms-file text file will be created upon server launch, but will disappear if a user leaves that respective room (with or without files in the playlist). Shouldn't affect me personally but I don't think it's working as intended.

@haz429 f555c1d should resolve the issue of permanent rooms disappearing when it becomes empty.