mpvSyncplaySocket created in $HOME

[notpeelz]

Describe the bug
Since 459c9e9, a file named mpvSyncplaySocket is created in my home folder.

Expected behavior
On Linux, these kind of files would normally be created under $XDG_RUNTIME_DIR.
This env var might be undefined on non-systemd setups, in which case it should probably default to $TMPDIR (and fall back to /tmp if undefined).

Or as the XDG Base Directory spec puts it:

$XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and other file objects (such as sockets, named pipes, ...) should be stored.

You can find more information about the standard file hierarchy (as defined by systemd) here: https://man7.org/linux/man-pages/man7/file-hierarchy.7.html

Version and platform:

• OS: Arch Linux
• Syncplay version: Syncplay 1.7.2
• Media player and version: MPV 0.37.0

[Et0h]

Thanks for reporting this issue. I use Windows rather than Linux so am not in a position to fix and test this, but hopefully someone can do so in a way that works on Linux and doesn't break anything on macOS or Windows and make a pull request.

As per #529 and #651 the concept behind the change is to ensure that people can still connect to mpv IPC sockets even when Syncplay is also connected.

[port19x]

So this is where these mystery files have been coming from