Fixing some unicode and Italian translation issues#179
Merged
Et0h merged 6 commits intoSyncplay:masterfrom Apr 7, 2018
Merged
Conversation
… file differences
…g of the file properties
…aracters on macOS
Contributor
|
I'm hoping to release 1.5.3 soon to fix an issue with HTTPS on the Windows builds. Is this okay to merge or does it need more tweaks to resolve the outstanding issues? |
Contributor
|
Tested on Windows and everything in patch seems fine. As otherwise discussed the file difference issue still needs resolving for macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am experimenting with files with non-ASCII characters in their name or path, and I have found some issues in the current version. In the following, there is a detailed list of what I found so far and how I fixed it. I am using this PR to keep track of these bugs and changes, since I am currently in the process of finding and debugging some of them.
Unicode support
Italian translation
Other (not a bug probably):