Remove ruby reinstall workaround for openssl, as not needed#279
Merged
albertosottile merged 1 commit intoSyncplay:masterfrom Mar 22, 2020
Merged
Remove ruby reinstall workaround for openssl, as not needed#279albertosottile merged 1 commit intoSyncplay:masterfrom
albertosottile merged 1 commit intoSyncplay:masterfrom
Conversation
Member
|
Just saw this MR, I was about to try this myself. Let's see if that is the right call. Thanks for the fast fix! |
Contributor
Author
Looks like the build passed, so LGTM. Thanks for the tool! It's been useful to me at the past, and so I figured I'd try and fix the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it turns out the workaround hack in #275 isn't needed any more, probably due to the homebrew changes there restricting the alterations to the filesystem. https://travis-ci.org/github/palfrey/syncplay/jobs/665559940 demos a upload being done, and other than it failing due to authorisation issues (which hopefully are just due to it being on my fork, not the main repo) it should hopefully work now!