client: add simple wildcard matching mechanism for trusted domains#306
Merged
Et0h merged 1 commit intoSyncplay:masterfrom May 2, 2020
Merged
client: add simple wildcard matching mechanism for trusted domains#306Et0h merged 1 commit intoSyncplay:masterfrom
Et0h merged 1 commit intoSyncplay:masterfrom
Conversation
Contributor
|
Cheers. Tested it and it seems to allow you to add *.xyz.com as trusted domain and it will then accept abc.xyz.com as a trusted domain, thus resolving the use cases provided by #305 |
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #305