Allow playlists to be played from network#419
Conversation
|
@zeroeightysix Would it be better to use the specific HTTP(S) check as proposed or the more generic utils.isURL protocol check which catches all :// paths? |
|
Syncplay is not designed to load .m3u and .m3u8 files directly, it leaves that to the media player. If you have a specific use case that is improved by the change then please specify it in more details. |
I'm not sure. I guess this might allow videos to be played over
I made this PR to solve mpv not being able to play a video (supplied as m3u over the network) through syncplay, while it was able to play the video if ran from the terminal (using I did not check for compliance with any other media player, for which my apologies. |
|
I tested the PR with mpv, mpv.net, VLC, MPC-HC (1.9.8) and it worked. As usual, streaming works best with Syncplay when using mpv/mpv.net due to how they handle seeks to areas which have yet to be buffered. I used a Big Buck Bunny test stream: |
* Create pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * Update pythonpackage.yml * add libxcb manually * Add missing libxcb-util to build environment * Remove references to IRC (#430) * Add reference to GitHub discussions * Update issue templates * Revert "Merge branch 'master' into master" This reverts commit 173007e, reversing changes made to 6105da8. * Make Windows build 32-bit * Support for LAV Filters Megamix (#457) * Upver to 1.7.0 (r100) * Refactor MPC-HC player path code (#453) * Add LANG Parameter (#460) If LANG parameter set, don't show language dialog. Example usage: .\Syncplay-X.X.X-Setup.exe /S /LANG=1033 * Trusted Domains: Allow trusting a domain regardless of HTTP basic auth credentials (#437) * Trusted Domains: don't consider HTTP basic auth credentials part of the domain name * Trusted Domains: hide "add as trusted domain" menu item if entry does not contain domain * Trusted Domains: strip HTTP basic auth credentials also when adding as trusted domain via context menu * Allow .m3u/.m3u8 files to be played from network (#419) * Fix room name case sensitivity UI issue (#403) * Remove redundant help button from dialogs (#403) * darkdetect: update vendor copy to 0.5.0 * macOS build: upgrade to Python 3.9 and PySide2 5.15.2 * Remove Encoding from .desktop files as it's depreciated now. * Add Keywords entry to .desktop files. * Console: Document setting offset in help (#435) * Add deprecation notice for offset help (#435) * Begin move from m3u/m3u8 to txt for playlist (#408) Co-authored-by: Daniel Wróbel <wrobel.dan@gmail.com> Co-authored-by: daniel-123 <1662391+daniel-123@users.noreply.github.com> Co-authored-by: Assistant <assistant.moetron@gmail.com> Co-authored-by: ImportTaste <53661808+ImportTaste@users.noreply.github.com> Co-authored-by: Ata Gülalan <xava@hotmail.com.tr> Co-authored-by: Tremolo4 <Tremolo4@users.noreply.github.com> Co-authored-by: Ridan Vandenbergh <RidanVandenbergh@gmail.com> Co-authored-by: Alberto Sottile <alby128@gmail.com> Co-authored-by: Luke Dashjr <luke_github1@dashjr.org>
.m3u,.m3u8(and probably txts as well) are frequently hosted on the web for TV stations, videos, and other media.This PR checks if the "file path" starts with
http://orhttps://, and, if so, does not try to load those 'files' from filesystem.Previously syncplay would not be able to load videos from the internet through the
File > Open media stream URLmenu as it'd try to load them from the FS.