change type, of file in ConfigurationGetter.py from str to utf-8#85
Merged
Et0h merged 1 commit intoSyncplay:masterfrom Dec 15, 2015
Merged
change type, of file in ConfigurationGetter.py from str to utf-8#85Et0h merged 1 commit intoSyncplay:masterfrom
Et0h merged 1 commit intoSyncplay:masterfrom
Conversation
Contributor
|
Tested in Windows and it doesn't seem to break anything. Unicode for file path arguments in Windows is already broken (due to how Python gets the arguments), so people have to open Syncplay then the file if they want to open Unicode files. |
Et0h
added a commit
that referenced
this pull request
Dec 15, 2015
Fix non-Windows Unicode file path argument bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed the type, of file in argparser so that files can accept unicode characters