Fix fatal error when another the_content filter callback returns null instead of a string #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Build for testing: webp-uploads.zip |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
changed the title
adamsilverstein
approved these changes
Jun 6, 2024
westonruter
commented
Jun 6, 2024
Comment on lines
-853
to
-866
| /** | ||
| * Tests that the fallback script is not added when a post with no updated images is rendered. | ||
| */ | ||
| public function test_it_should_not_add_fallback_script_if_content_has_no_updated_images(): void { | ||
| remove_all_actions( 'wp_footer' ); | ||
|
|
||
| apply_filters( 'the_content', '<p>no image</p>' ); | ||
|
|
||
| $this->assertFalse( has_action( 'wp_footer', 'webp_uploads_webp_fallback' ) ); | ||
|
|
||
| $footer = get_echo( 'wp_footer' ); | ||
| $this->assertStringNotContainsString( 'webp;base64,UklGR', $footer ); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This should have been removed as part of #1269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a support topic, a user reported a fatal error:
Uncaught TypeError: webp_uploads_update_image_references(): Argument #1 ($content) must be of type string, null givenIt appears there is some other plugin which adds a
the_contentfilter which returnsnullinstead of astring. Sincewebp_uploads_update_image_references()is added as a filter, it should be updated to guard against this case by allowingmixedas the input, as we've done for other filters. This stems from work in #775.