Circuitpython doesn't compile when disabling BLE (including working quick fix)

[meatdryer]

CircuitPython version and board name

Adafruit CircuitPython 10.0.1 on 2025-10-09; Adafruit Feather ESP32S3 4MB Flash 2MB PSRAM with ESP32S3

Code/REPL

mpconfigboard.mk:

CIRCUITPY_BLE_FILE_SERVICE = 0
CIRCUITPY_SERIAL_BLE = 0

Behavior

Circuitpython won't build when disabling BLE_FILE_SERVICE and SERIAL_BLE.

PacketBuffer.c seems to be missing a compilation guard when the build flags are set. It seems like the prototype is removed from the header file but the implementation still exists in the C-file.

There also seems to be a parameter mis-match between the header-file and the C-file:
max_packet_size vs. outgoing_buffer_size

-- Compilation error:
GEN build-adafruit_feather_esp32s3_4mbflash_2mbpsram/genhdr/root_pointers.h
common-hal/_bleio/PacketBuffer.c:162:6: error: no previous prototype for '_common_hal_bleio_packet_buffer_construct' [-Werror=missing-prototypes]
162 | void _common_hal_bleio_packet_buffer_construct(

-- Quick fix that works:

shared-bindings/_bleio/PacketBuffer.h:
(Line 28)
uint32_t *outgoing_buffer1, uint32_t *outgoing_buffer2, size_t outgoing_buffer_size,
--->
uint32_t *outgoing_buffer1, uint32_t *outgoing_buffer2, size_t max_packet_size,

ports/espressif/common-hal/_bleio/PacketBuffer.c
(Line 162)
#if CIRCUITPY_SERIAL_BLE || CIRCUITPY_BLE_FILE_SERVICE // Exposed via shared-bindings header when enabled void _common_hal_bleio_packet_buffer_construct( #else // Internal static helper when disabled (avoids "missing prototype" error) static void _common_hal_bleio_packet_buffer_construct( #endif

Description

No response

Additional information

No response

[tannewt]

We don't use this setup so it'll be up to someone else to fix. Happy to merge any fixes though.

[daniel-alsen]

I can make the change if you want to review and merge. What are the steps? I haven't contributed to this codebase before.

[dhalbert]

Thanks! Here's a guide: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

[daniel-alsen]

Thanks!

I added this fix as I though it could be a helpful feature for others who don't use the BLE file services and wants to speed up the board startup sequence by removing the flashing blue and flashing yellow led delay.

It works together with CIRCUITPY_SKIP_SAFE_MODE_WAIT = 0 which already works well.

I tested it with flags enabled and disabled.

I created pull request towards the main branch that I just closed, as I realized that 10.0.x seems to be the target now. Here is the new pull request I created:

#10755

Hope I did it right, I tried to follow the guide and all the instructions.