This repository was archived by the owner on Nov 17, 2023. It is now read-only.
fixed overwrite of args/aux variables#18232
Merged
marcoabreu merged 2 commits intoapache:masterfrom May 7, 2020
Merged
Conversation
|
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [clang, windows-gpu, unix-gpu, unix-cpu, website, centos-gpu, edge, windows-cpu, miscellaneous, centos-cpu, sanity] Note: |
Contributor
Author
|
@mxnet-label-bot add [Bug] |
This was referenced May 4, 2020
Merged
Merged
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
* fixed overwrite of args/aux variables * fixed spacing
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Jul 24, 2020
* fixed overwrite of args/aux variables * fixed spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix overwriting of args/aux variables in optimize_for API to enable modifying the user-provided objects for adding new params for graph passes.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.