Switch to GCC 9 for static build#19034
Conversation
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [unix-gpu, centos-gpu, unix-cpu, windows-cpu, clang, website, miscellaneous, windows-gpu, centos-cpu, sanity, edge] Note: |
|
@mxnet-bot run ci [windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu] |
|
@mxnet-bot run ci [windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu] |
tools/pip/setup.py
Outdated
| else: | ||
| shutil.copy(os.path.join(libdir, 'libgfortran.so.5'), mxdir) | ||
| package_data['mxnet'].append('mxnet/libgfortran.so.5') |
There was a problem hiding this comment.
it's possible that user compiled and statically linked libgfortran or this file isn't necessary, so I'd recommend to add the condition check.
There was a problem hiding this comment.
The tools/pip/ is currently coupled with the tools/staticbuild. We should uncouple them but I think it can be part of a separate PR.
szha
left a comment
szha
left a comment
There was a problem hiding this comment.
I'm OK with addressing the comment in a separate PR if author prefers.
Co-authored-by: Sheng Zha <[email protected]>
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
4 participants
Description
Use GCC 9 for building libmxnet.so in the static build Dockerfiles / on CD:
https://www.phoronix.com/scan.php?page=article&item=gcc9-eoy-2018
Also fix file exists check in tools/dependencies/protobuf.sh
The build continues to run on CentOS7 and meet the manylinux2014 requirements.