Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[PIP] add build target in cmake for osx compat#19110

Merged
szha merged 2 commits intoapache:masterfrom
szha:osx_deploy_target
Sep 11, 2020
Merged

[PIP] add build target in cmake for osx compat#19110
szha merged 2 commits intoapache:masterfrom
szha:osx_deploy_target

Conversation

@szha
Copy link
Member

@szha szha commented Sep 10, 2020

Description

add build target in cmake for osx compat with CMAKE_OSX_DEPLOYMENT_TARGET

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

@szha szha requested a review from leezu September 10, 2020 15:23
@mxnet-bot
Copy link

mxnet-bot commented Sep 10, 2020

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, windows-gpu, unix-cpu, unix-gpu, centos-cpu, centos-gpu, edge, windows-cpu, sanity, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha szha merged commit 95e1814 into apache:master Sep 11, 2020
@szha szha deleted the osx_deploy_target branch September 11, 2020 04:38
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
Closed
13 tasks
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Feb 19, 2021
@szha
[PIP] add build target in cmake for osx compat (apache#19110)
aab2e4a 
* add build target in cmake for osx compat

* update wheel tags
@access2rohit access2rohit mentioned this pull request Feb 19, 2021
Merged
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Feb 22, 2021
@szha
[PIP] add build target in cmake for osx compat (apache#19110)
a746153 
* add build target in cmake for osx compat

* update wheel tags
ChaiBapchya pushed a commit that referenced this pull request Feb 22, 2021
@access2rohit @szha
[PIP] add build target in cmake for osx compat (#19110) (#19926)
c97e89c 
* add build target in cmake for osx compat

* update wheel tags

Co-authored-by: Sheng Zha <[email protected]>
@szha szha mentioned this pull request Apr 5, 2021
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@leezu leezu leezu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szha @mxnet-bot @leezu