This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Disable ENABLE_TESTCOVERAGE on CentOS 7 build#19507
Merged
leezu merged 2 commits intoapache:masterfrom Nov 10, 2020
Merged
Conversation
Causes significant slowdown in connection with the system (devtoolset) provided OpenMP libraries.
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [sanity, windows-cpu, edge, centos-gpu, unix-cpu, unix-gpu, centos-cpu, windows-gpu, clang, website, miscellaneous] Note: |
bc20382 to
8340dd1
Compare
Contributor
Author
|
@mseth10 any idea about the difference in |
Contributor
|
Seems to be an outlier, all other tests run faster. Should we re-trigger centos-cpu for a second datapoint? |
Contributor
Author
|
I think we can merge the PR and observe the performance on the master branch. |
vidyaravipati
pushed a commit
to vidyaravipati/incubator-mxnet
that referenced
this pull request
Nov 11, 2020
Causes significant slowdown in connection with the system (devtoolset) provided OpenMP libraries. intgemm USE_OPENMP appears to pull in system openmp apache@1393602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causes significant slowdown in connection with the system (devtoolset) provided OpenMP libraries.
#17559 starts pulling in the system OpenMP in addition to the
3rdparty/openmpcausing the slowdown to materialize after the merge of #17559.Fixes #19502
Let's still fix the issue of intgemm pulling a second openmp @kpuatamazon
With this PR
Without this PR