Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[wip][v1.x] ONNX conversion for topk#19761

Merged
Zha0q1 merged 8 commits intoapache:v1.xfrom
Zha0q1:onnx_topk
Jan 22, 2021
Merged

[wip][v1.x] ONNX conversion for topk#19761
Zha0q1 merged 8 commits intoapache:v1.xfrom
Zha0q1:onnx_topk

Conversation

@Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Jan 15, 2021 •
edited
Loading

Topk operator. I also added support for when a node has multiple outputs. Test cases are added to make sure nodes with multiple outputs can be linked correctly to other nodes in a graph

@Zha0q1 Zha0q1 requested a review from szha as a code owner January 15, 2021 21:51
@mxnet-bot
Copy link

mxnet-bot commented Jan 15, 2021

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, miscellaneous, centos-gpu, unix-cpu, windows-gpu, unix-gpu, website, sanity, windows-cpu, edge, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@Zha0q1 Zha0q1 changed the title [v1.x] ONNX conversion for _maximum_scalar [v1.x] ONNX conversion for topk Jan 15, 2021
@Zha0q1 Zha0q1 changed the title [v1.x] ONNX conversion for topk [wip][v1.x] ONNX conversion for topk Jan 16, 2021
waytrue17
waytrue17 reviewed Jan 16, 2021
View reviewed changes
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 19, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 20, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 21, 2021
josephevans
josephevans approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 21, 2021
@lanking520 lanking520 removed the pr-awaiting-review PR is waiting for code review label Jan 21, 2021
@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 21, 2021
waytrue17
waytrue17 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 22, 2021
@Zha0q1 Zha0q1 merged commit 93ae5cf into apache:v1.x Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@josephevans josephevans josephevans approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520