This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] fix numpy op fallback bug when ndarray in kwargs#20233
Merged
leezu merged 2 commits intoapache:masterfrom May 3, 2021
Merged
[BUGFIX] fix numpy op fallback bug when ndarray in kwargs#20233leezu merged 2 commits intoapache:masterfrom
leezu merged 2 commits intoapache:masterfrom
Conversation
|
Hey @wkcn , Thanks for submitting the PR
CI supported jobs: [clang, unix-gpu, windows-cpu, centos-cpu, miscellaneous, unix-cpu, windows-gpu, website, edge, centos-gpu, sanity] Note: |
wkcn
commented
May 3, 2021
wkcn
commented
May 3, 2021
wkcn
commented
May 3, 2021
Member
Author
wkcn
left a comment
There was a problem hiding this comment.
The two positions may be made some change.
szha
approved these changes
May 3, 2021
Member
szha
left a comment
There was a problem hiding this comment.
Good catch and LGTM. Feel free to apply the suggested changes too.
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi there,
This PR fixes the issue #20232
When a operator is not implemented in MXNet, it will be fallbacked to official numpy operator.
However, it triggers a bug when the NDArray only exist in
kwargs.Reproduce Example:
The reason is that the function
_as_onp_arrayinmultiarray.py#L380could not discriminate the NDArray inkwargs.Checklist
Essentials
Changes
_as_onp_arrayinmultiarray.py#L380support NDArray inkwargs.