This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] Fix CI slowdown issue after removing 3rdparty/openmp#20367
Merged
akarbown merged 2 commits intoapache:masterfrom Jun 22, 2021
Merged
[BUGFIX] Fix CI slowdown issue after removing 3rdparty/openmp#20367akarbown merged 2 commits intoapache:masterfrom
akarbown merged 2 commits intoapache:masterfrom
Conversation
|
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [unix-gpu, centos-gpu, miscellaneous, unix-cpu, windows-cpu, clang, centos-cpu, sanity, edge, windows-gpu, website] Note: |
Contributor
|
Thanks for the fix! Is this pr ready to merge now? Also do we know if this is the only slowdown? |
Contributor
|
@bgawrych, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes slowdown on CI (#20092) introduced after removing 3rdparty/openmp.
GOMP by default doesn't use OMP_DYNAMIC and OMP_NESTED which allows to run parallel regions inside other parallel region.
e.g.
Even if there is "if" directive causing sequential run it's still treated as parallel region - setting OMP_DYNAMIC and OMP_NESTED somewhat helps, but seems that without "if" clause in GOMP we get even better performance and we don't need to set above env variables.
CC: @akarbown
Checklist
Essentials