[v1.x] License updates per ASF feedback#20377
Conversation
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [centos-cpu, windows-cpu, unix-cpu, website, clang, centos-gpu, sanity, edge, windows-gpu, miscellaneous, unix-gpu] Note: |
| R-package | ||
| 3rdparty/mkldnn/doc | ||
| 3rdparty/googletest/ci | ||
| docs |
There was a problem hiding this comment.
docs folder also contains the install instructions (build_from_source page)
There was a problem hiding this comment.
I would think most users building from source are following instructions from a web site, not viewing them from the source tree (after all, they are in .md format and would require viewing through a formatter/browser.) Do you think it's a requirement to ship them out in the source archive though?
There was a problem hiding this comment.
I don't think it's a requirement, but it's not ideal as the website may change over time, while the archive remains fixed.
There was a problem hiding this comment.
True, but the git version tag will always be there.
There was a problem hiding this comment.
I think at least a link to the install instructions is needed
There was a problem hiding this comment.
Have you or have you heard anyone use the docs inside the release package?
There was a problem hiding this comment.
@josephevans Can we only keep the install instructions?
There was a problem hiding this comment.
If you mean the build instructions, they are in https://github.com/apache/incubator-mxnet/blob/v1.x/docs/static_site/src/pages/get_started/build_from_source.md - we could copy this file to the root source archive. Alternatively, we could create a README.txt file with a link to the instructions on the web-site (but the latest version would have to be published.)
|
Removing entire docs directory just because of few fonts seems like quite a heavy handed approach. Could we instead just download those fonts as part of docs CD pipeline? |
I agree that it's a fairly drastic change, but I am not convinced many users actually use the docs from the source archive. It takes a bit of effort to get them built and requires viewing them through a browser, and I would bet most people don't go through this effort and just use the documentation online. |
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
…ributed in source archive,) and remove SIL open font license and reference in LICENSE.
f929c54 to
df4a0ab
Compare
* switch to DISCLAIMER (apache#20242) Signed-off-by: Sheng Zha <zhasheng@amazon.com> * Don't distribute 3rdparty/googletest/ci in source archive. * Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn. * Do not distribute docs/ subdir in source archive. * Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE. Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Joe Evans <joeev@amazon.com>
* switch to DISCLAIMER (apache#20242) Signed-off-by: Sheng Zha <zhasheng@amazon.com> * Don't distribute 3rdparty/googletest/ci in source archive. * Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn. * Do not distribute docs/ subdir in source archive. * Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE. Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Joe Evans <joeev@amazon.com>
* [v1.x] License updates per ASF feedback (#20377) * switch to DISCLAIMER (#20242) Signed-off-by: Sheng Zha <zhasheng@amazon.com> * Don't distribute 3rdparty/googletest/ci in source archive. * Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn. * Do not distribute docs/ subdir in source archive. * Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE. Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Joe Evans <joeev@amazon.com> * Merge in Zhaoqi's ONNX license changes. Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Joe Evans <joeev@amazon.com>
Address licensing concerns raised by our IPMC mentors: