Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.#20492

Merged
mseth10 merged 2 commits intoapache:v1.9.xfrom
josephevans:issue1_v1.9.x
Aug 9, 2021
Merged

[v1.9.x] Make sure files with 2 licenses are listed properly in LICENSE.#20492
mseth10 merged 2 commits intoapache:v1.9.xfrom
josephevans:issue1_v1.9.x

Conversation

@josephevans
Copy link
Contributor

@josephevans josephevans commented Aug 6, 2021

Action item 1 from #20475.

@mxnet-bot
Copy link

mxnet-bot commented Aug 6, 2021

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, website, windows-cpu, unix-cpu, centos-cpu, clang, windows-gpu, centos-gpu, edge, miscellaneous, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 6, 2021
sandeep-krishnamurthy
sandeep-krishnamurthy reviewed Aug 6, 2021
View reviewed changes
LICENSE
python/mxnet/onnx/mx2onnx/_export_onnx.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
src/operator/numpy/np_einsum_op-inl.h
Copy link

@sandeep-krishnamurthy sandeep-krishnamurthy Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we list functions of BSD clause.

Copy link
Contributor Author

@josephevans josephevans Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the history of the file, it seems as if it was heavily modified, so I think we are correct to release it under ASF 2.0 license and don't need to call out specific functions.

Copy link
Contributor Author

@josephevans josephevans Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also don't call out specific functions in other files in this LICENSE category.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 6, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 8, 2021
mseth10
mseth10 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 merged commit 347e9b0 into apache:v1.9.x Aug 9, 2021
@josephevans josephevans mentioned this pull request Aug 9, 2021
Merged
6 tasks
josephevans added a commit to josephevans/mxnet that referenced this pull request Aug 12, 2021
@josephevans
[v1.9.x] Make sure files with 2 licenses are listed properly in LICEN…
330ebf2 
…SE. (apache#20492)

* Make sure files with 2 licenses are listed properly in LICENSE.

* Remove ASF copyright line.
@josephevans josephevans mentioned this pull request Aug 12, 2021
Merged
josephevans added a commit to josephevans/mxnet that referenced this pull request Aug 12, 2021
@josephevans
[v1.9.x] Make sure files with 2 licenses are listed properly in LICEN…
4508e94 
…SE. (apache#20492)

* Make sure files with 2 licenses are listed properly in LICENSE.

* Remove ASF copyright line.
@josephevans josephevans mentioned this pull request Aug 12, 2021
Merged
sandeep-krishnamurthy pushed a commit that referenced this pull request Aug 12, 2021
@josephevans
[v1.9.x] Make sure files with 2 licenses are listed properly in LICEN…
3f7321e 
…SE. (#20492) (#20518)

* Make sure files with 2 licenses are listed properly in LICENSE.

* Remove ASF copyright line.
Zha0q1 pushed a commit that referenced this pull request Aug 14, 2021
@josephevans
[v1.9.x] Make sure files with 2 licenses are listed properly in LICEN…
18ceff5 
…SE. (#20492) (#20519)

* Make sure files with 2 licenses are listed properly in LICENSE.

* Remove ASF copyright line.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy left review comments

@mseth10 mseth10 mseth10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephevans @mxnet-bot @sandeep-krishnamurthy @mseth10