Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Master] Clang-format description on a wiki#20612

Merged
szha merged 3 commits intoapache:masterfrom
mozga-intel:mozga-intel/clang_desciption
Oct 15, 2021
Merged

[Master] Clang-format description on a wiki#20612
szha merged 3 commits intoapache:masterfrom
mozga-intel:mozga-intel/clang_desciption

Conversation

@mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Sep 27, 2021

Description

This pull request describes how to set up clang-format tool as a part of your worklow.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Sep 27, 2021

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-cpu, clang, miscellaneous, unix-gpu, website, windows-gpu, edge, centos-cpu, sanity, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Sep 27, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Sep 27, 2021

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Sep 27, 2021

Jenkins CI successfully triggered : [centos-cpu]

@mozga-intel mozga-intel force-pushed the mozga-intel/clang_desciption branch from f1066a8 to 5c512d6 Compare September 27, 2021 10:51
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Sep 27, 2021

@mxnet-bot run ci [unix-cpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Sep 27, 2021

Jenkins CI successfully triggered : [website, unix-cpu]

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Sep 27, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Sep 27, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mozga-intel
Copy link
Contributor Author

mozga-intel commented Sep 28, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Sep 28, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mozga-intel mozga-intel marked this pull request as ready for review September 28, 2021 15:24
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Oct 14, 2021

@szha Could you please review this pull request? Thanks!

szha
szha reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the content. Can the guide be incorporated into other contribution guides, or at least referenced from them?

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Oct 15, 2021

@mxnet-bot run ci [centos-cpu, unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 15, 2021

Jenkins CI successfully triggered : [unix-cpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Oct 15, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 15, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Oct 15, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 15, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@mozga-intel
Copy link
Contributor Author

mozga-intel commented Oct 15, 2021

Thanks! @szha, a link to the description is shifted into other contribution guides.

@szha szha merged commit f46b25b into apache:master Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

1 more reviewer

@szha szha szha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mozga-intel @mxnet-bot @szha @mseth10