Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[API STD][LINALG] Standardize sort & linalg operators#20694

Merged
szha merged 9 commits intoapache:masterfrom
barry-jin:standard-other
Nov 3, 2021
Merged

[API STD][LINALG] Standardize sort & linalg operators#20694
szha merged 9 commits intoapache:masterfrom
barry-jin:standard-other

Conversation

@barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Oct 22, 2021

Description

  • Standradize argsort, sort, linalg.cholesky, linalg.pinv, linalg.matrix_rank.
  • Update related tests

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@barry-jin barry-jin requested a review from szha as a code owner October 22, 2021 23:27
@mxnet-bot
Copy link

mxnet-bot commented Oct 22, 2021

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, centos-gpu, edge, centos-cpu, website, unix-cpu, clang, windows-gpu, windows-cpu, sanity, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 22, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
@barry-jin barry-jin mentioned this pull request Oct 22, 2021
Open
52 tasks
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 25, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 25, 2021

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 25, 2021

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 25, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 25, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 25, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 25, 2021
@barry-jin barry-jin changed the title [API] Standardize sort & linalg operators [API STD][LINALG] Standardize sort & linalg operators Oct 28, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Oct 28, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 31, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 31, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 31, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 31, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 31, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Nov 1, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 1, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 1, 2021
@szha szha merged commit 9e6dd92 into apache:master Nov 3, 2021
@barry-jin barry-jin deleted the standard-other branch November 3, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barry-jin @mxnet-bot @szha @mseth10