Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[master] Merge DNNL adaptive pooling with standard pooling#20741

Merged
bgawrych merged 5 commits intoapache:masterfrom
piotrwolinski-intel:piotrwolinski/adaptive-pooling-merge-master
Nov 23, 2021
Merged

[master] Merge DNNL adaptive pooling with standard pooling#20741
bgawrych merged 5 commits intoapache:masterfrom
piotrwolinski-intel:piotrwolinski/adaptive-pooling-merge-master

Conversation

@piotrwolinski-intel
Copy link
Contributor

@piotrwolinski-intel piotrwolinski-intel commented Nov 15, 2021

Description

DNNL adaptive and standard pooling now have one implementation with single type of Parameter - PoolingParam

@mxnet-bot
Copy link

mxnet-bot commented Nov 15, 2021

Hey @piotrwolinski-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, windows-gpu, miscellaneous, clang, website, unix-cpu, unix-gpu, centos-gpu, edge, sanity, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 15, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 15, 2021
bartekkuncer
bartekkuncer reviewed Nov 15, 2021
View reviewed changes
src/operator/contrib/adaptive_avg_pooling.cc Outdated
CHECK_EQ(inputs.size(), 1U);
CHECK_EQ(outputs.size(), 1U);
/*
OneDNN doesn't support adaptive pooling.
Copy link
Contributor

@bartekkuncer bartekkuncer Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneDNN*
Also is this comment up-to-date?

Copy link
Contributor Author

@piotrwolinski-intel piotrwolinski-intel Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, from what I've checked it is still up-to-date, but some verification would be appreciated

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 15, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 17, 2021
@piotrwolinski-intel
Copy link
Contributor Author

piotrwolinski-intel commented Nov 18, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 18, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2021
@piotrwolinski-intel
Copy link
Contributor Author

piotrwolinski-intel commented Nov 22, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 22, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 22, 2021
@piotrwolinski-intel
Copy link
Contributor Author

piotrwolinski-intel commented Nov 22, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Nov 22, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 22, 2021
bgawrych
bgawrych approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@bgawrych bgawrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgawrych bgawrych merged commit 2e8e0ae into apache:master Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bgawrych bgawrych bgawrych approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@piotrwolinski-intel @mxnet-bot @bgawrych @bartekkuncer @mseth10