This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Restore quantized RNN operator from MXNet 1.6#20759
Merged
bgawrych merged 8 commits intoapache:v1.xfrom Dec 3, 2021
Merged
[v1.x] Restore quantized RNN operator from MXNet 1.6#20759bgawrych merged 8 commits intoapache:v1.xfrom
bgawrych merged 8 commits intoapache:v1.xfrom
Conversation
bgawrych
requested review from
anirudh2290,
eric-haibin-lin and
szha
as code owners
|
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [unix-gpu, miscellaneous, windows-cpu, sanity, clang, website, centos-cpu, centos-gpu, unix-cpu, edge, windows-gpu] Note: |
mseth10
added
pr-awaiting-testing
bgawrych
force-pushed
the
bring_back_q_rnn
branch
from
95d70c3 to
8c57e7b
Compare
mseth10
added
pr-awaiting-testing
bgawrych
force-pushed
the
bring_back_q_rnn
branch
from
8c57e7b to
82c647a
Compare
mseth10
added
pr-awaiting-testing
bgawrych
force-pushed
the
bring_back_q_rnn
branch
from
82c647a to
70642ac
Compare
mseth10
added
pr-awaiting-testing
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
anko-intel
reviewed
Nov 30, 2021
josephevans
approved these changes
Nov 30, 2021
josephevans
reviewed
Nov 30, 2021
mseth10
added
pr-awaiting-testing
bartekkuncer
suggested changes
Dec 1, 2021
mseth10
added
pr-awaiting-testing
Contributor
Author
|
@josephevans @bartekkuncer @anko-intel Can you take a quick look again and check if your comments was resolved? |
josephevans
approved these changes
Dec 2, 2021
Contributor
josephevans
left a comment
josephevans
left a comment
There was a problem hiding this comment.
Thanks for the updates, looks good.
anko-intel
approved these changes
Dec 2, 2021
bartekkuncer
approved these changes
Dec 2, 2021
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Jan 11, 2022
* restore but seg fault * Refactor & seg fault fixed * apply formatter * fix sanity * Fix docs build * anko review * Remove copyright by contributors from touched files * remove comments / apply formatter
josephevans
added a commit
that referenced
this pull request
Jan 12, 2022
* [v1.x] Restore quantized RNN operator from MXNet 1.6 (#20759) * restore but seg fault * Refactor & seg fault fixed * apply formatter * fix sanity * Fix docs build * anko review * Remove copyright by contributors from touched files * remove comments / apply formatter * Update call to work with older mkldnn version. Co-authored-by: bgawrych <bartlomiej.gawrych@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is backport of this change: #18028
with additional refactor & bug fixes from current v1.x branch
Connected to issue: #20737
@ssriram1978
@josephevans
Test are passing, however feedback if everything works fine in your model would be appreciated