Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fix oneDNN fallback for concat with scalar#20772

Merged
bgawrych merged 2 commits intoapache:masterfrom
bgawrych:concat_fallback_fix
Jan 5, 2022
Merged

Fix oneDNN fallback for concat with scalar#20772
bgawrych merged 2 commits intoapache:masterfrom
bgawrych:concat_fallback_fix

Conversation

@bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Dec 9, 2021

Description

In gluon-nlp repository following bug can be observer:

raise get_last_ffi_error()
1525E mxnet.base.MXNetError: Traceback (most recent call last):
1526E File "../src/ndarray/ndarray.cc", line 606
1527E MXNetError: oneDNN doesn't support 0 dimensions

PR: dmlc/gluon-nlp#1581
CI Run: https://github.com/dmlc/gluon-nlp/runs/4397405377?check_suite_focus=true

@mxnet-bot
Copy link

mxnet-bot commented Dec 9, 2021

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, unix-cpu, edge, clang, website, windows-cpu, miscellaneous, unix-gpu, centos-gpu, centos-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@bgawrych bgawrych changed the title Concat fallback fix Fix oneDNN fallback for concat with scalar Dec 9, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 9, 2021
@bgawrych bgawrych mentioned this pull request Dec 9, 2021
Merged
@bgawrych bgawrych force-pushed the concat_fallback_fix branch from 5bd0964 to 5f70b03 Compare December 15, 2021 13:58
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 16, 2021

@mxnet-bot run ci [centos-gpu, centos-cpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Dec 16, 2021

Jenkins CI successfully triggered : [unix-gpu, centos-cpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 16, 2021
@bgawrych bgawrych force-pushed the concat_fallback_fix branch from 5f70b03 to 3358912 Compare January 4, 2022 08:20
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 4, 2022
PawelGlomski-Intel
PawelGlomski-Intel approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@PawelGlomski-Intel PawelGlomski-Intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgawrych bgawrych merged commit 0c3ef7a into apache:master Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@RafLit RafLit RafLit approved these changes

@PawelGlomski-Intel PawelGlomski-Intel PawelGlomski-Intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bgawrych @mxnet-bot @RafLit @PawelGlomski-Intel @mseth10