Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX]Fix the regular expression in RTC code#20810

Merged
marcoabreu merged 1 commit intoapache:masterfrom
ptrendx:pr_rtc_regex
Jan 18, 2022
Merged

[BUGFIX]Fix the regular expression in RTC code#20810
marcoabreu merged 1 commit intoapache:masterfrom
ptrendx:pr_rtc_regex

Conversation

@ptrendx
Copy link
Member

@ptrendx ptrendx commented Jan 6, 2022

Description

This PR makes the regular expression in the legacy RTC code path more efficient.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Instead of checking for arbitrary number of whitespace character in the regular expression, I strip the input so that only a single whitespace is left between matched groups and modify the regular expression accordingly.

FYI @josephevans @szha @TristonC

@ptrendx ptrendx requested a review from szha as a code owner January 6, 2022 23:36
@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 6, 2022
szha
szha approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 7, 2022
@ptrendx
Copy link
Member Author

ptrendx commented Jan 7, 2022

@mxnet-bot run ci [unix-cpu, website, windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 7, 2022

Jenkins CI successfully triggered : [unix-cpu, windows-gpu, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 7, 2022
@ptrendx
Copy link
Member Author

ptrendx commented Jan 7, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 7, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 7, 2022
@szha
Copy link
Member

szha commented Jan 9, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 9, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 9, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 11, 2022
@TristonC
Copy link
Contributor

TristonC commented Jan 14, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 14, 2022

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@ptrendx
Copy link
Member Author

ptrendx commented Jan 14, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jan 14, 2022

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 14, 2022
josephevans
josephevans approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has finally passed! LGTM!

@marcoabreu marcoabreu merged commit 59b4c18 into apache:master Jan 18, 2022
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Jan 24, 2022
@ptrendx @josephevans
Fix the regular expression in RTC code (apache#20810)
c73dc7b
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Jan 24, 2022
@ptrendx @josephevans
Fix the regular expression in RTC code (apache#20810)
8b1508a
This was referenced Jan 24, 2022
Merged
Merged
josephevans added a commit that referenced this pull request Jan 25, 2022
@josephevans @ptrendx
Fix the regular expression in RTC code (#20810) (#20840)
ac4c8dc 
Co-authored-by: Przemyslaw Tredak <[email protected]>
josephevans added a commit that referenced this pull request Jan 27, 2022
@josephevans @ptrendx
Fix the regular expression in RTC code (#20810) (#20839)
2e2d717 
Co-authored-by: Przemyslaw Tredak <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@szha szha szha approved these changes

@josephevans josephevans josephevans approved these changes

@marcoabreu marcoabreu marcoabreu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ptrendx @mxnet-bot @szha @TristonC @josephevans @marcoabreu @mseth10