Skip to content

Conversation

@umitdemirci
Copy link
Contributor

No description provided.

Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Will merge once the CI runs :)

@katiewasnothere
Copy link
Contributor

Looks like your commits aren't signed. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification for setting up commit signatures.

@umitdemirci umitdemirci force-pushed the main branch 3 times, most recently from 781a41b to dcf28d6 Compare June 12, 2025 06:43
@umitdemirci
Copy link
Contributor Author

Looks like your commits aren't signed. Please see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification for setting up commit signatures.

Signed it.

@katiewasnothere
Copy link
Contributor

@umitdemirci Can you rebase your PR on main? Sorry about that, we fixed the proto generation here

@umitdemirci
Copy link
Contributor Author

@umitdemirci Can you rebase your PR on main? Sorry about that, we fixed the proto generation here

I think it's done :)

@katiewasnothere katiewasnothere merged commit c114945 into apple:main Jun 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants