container registry login host:port error fix #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhov
changed the title
Contributor
|
Hi @makhov thanks for the contribution! Could you rebase your PR and add signing to your commit (see the GitHub docs here)? Thanks! |
Contributor
Author
|
The pipeline fails because of some typos in Builder.grpc.swift. It's unrelated to the PR and fixed in #177. |
Contributor
|
@makhov You'll still need to rebase the PR to get the fix though unfortunately. Sorry about that! |
makhov
force-pushed
the
fix-login-cmd
branch
5 times, most recently
from
7cbd3e6 to
851c88b
Compare
Contributor
Author
|
No problem, done! I still don't understand, why my signed commit is unverified tho |
Contributor
|
@makhov Did you add your key on GitHub as a "signing" key instead of an auth one? |
Contributor
|
Thanks @makhov! The change itself looks good. Once we figure out the commit signatures, we can test and merge. |
Signed-off-by: Alexey Makhov <[email protected]>
Contributor
Author
|
Yes, I did. IDK what was wrong with it, but now it's fixed :) |
adityaramani
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Gets port from the given registry server URL and use it in a RegistryClient.