Improve error handling in answerHost #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Arer you sure we need to throw errors here? As far as I understood, the server collects results from different places and return https://github.com/apple/container/blob/main/Sources/DNSServer/DNSServer%2BHandle.swift#L59-L61 |
jglogan
requested changes
Jun 17, 2025
Refactor answerHost to throw descriptive `DNSResolverError` instances instead of returning nil when IP allocation or parsing fails.
eliseomartelli
force-pushed
the
eliseomartelli/throwerrors
branch
from
d5ab862 to
59ff0ce
Compare
Abdullah4345
approved these changes
Jun 22, 2025
jglogan
approved these changes
Jun 27, 2025
Contributor
|
@eliseomartelli Sorry for the delay, I was traveling this week. Approved and merged, thanks for improving those error responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
answerHostto throw descriptiveDNSResolverErrorinstancesinstead of returning nil when IP allocation or parsing fails.