Add a build parameter to handle warnings as errors #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiewasnothere
approved these changes
Sep 9, 2025
Contributor
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
LGTM once the merge conflicts are fixed
dkovba
force-pushed
the
dkovba/warnings-as-errors
branch
from
9932d66 to
015b375
Compare
katiewasnothere
approved these changes
Sep 9, 2025
jglogan
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle warnings as errors when building, use make. To allow warnings, use make WARNINGS_AS_ERRORS=false test.
Also see apple/containerization#271.