-
Notifications
You must be signed in to change notification settings - Fork 584
[how-to-docs]: Add steps for installation of completion scripts #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[how-to-docs]: Add steps for installation of completion scripts #799
Conversation
jglogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saehejkang Thanks, this is great! A bunch of comments here but they're mainly nits to match the contribution to the style of the rest of the doc. Have a look and follow up in comments if there's anything you think should be done differently.
|
@saehejkang Could you rework this commit so that your changes are rebased onto the head of Probably something like this on your local copy of your fork: Get the latest apple/container git checkout main
git fetch upstream
git merge upstream/mainGet rid of the merge commits in your feature branch, and sanity check your log to make sure you see the just your git checkout how-to-documentation-for-shell-auto-complete
git reset --hard c46212c
git logRebase your changes, and fix any merge conflicts you encounter, and then do a last sanity check to see that your diffs against main make sense: git rebase main
git diff mainOnce you're sure your local commit history looks good, rewrite your remote feature branch with the rebased commits: git push -f |
75be9ca to
f22abf3
Compare
Done! |
Type of Change
Motivation and Context
Closes #705
Testing
I tested all steps locally and developers should be able to just copy/paste the commands.