Skip to content

Conversation

@saehejkang
Copy link
Contributor

@saehejkang saehejkang commented Oct 22, 2025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #705

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

I tested all steps locally and developers should be able to just copy/paste the commands.

Copy link
Contributor

@jglogan jglogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saehejkang Thanks, this is great! A bunch of comments here but they're mainly nits to match the contribution to the style of the rest of the doc. Have a look and follow up in comments if there's anything you think should be done differently.

@jglogan
Copy link
Contributor

jglogan commented Oct 28, 2025

@saehejkang Could you rework this commit so that your changes are rebased onto the head of main, instead of merging main into the head of your branch?

Probably something like this on your local copy of your fork:

Get the latest apple/container main:

git checkout main
git fetch upstream
git merge upstream/main

Get rid of the merge commits in your feature branch, and sanity check your log to make sure you see the just your 791e092 and c46212c commits :

git checkout how-to-documentation-for-shell-auto-complete
git reset --hard c46212c
git log

Rebase your changes, and fix any merge conflicts you encounter, and then do a last sanity check to see that your diffs against main make sense:

git rebase main
git diff main

Once you're sure your local commit history looks good, rewrite your remote feature branch with the rebased commits:

git push -f

@saehejkang saehejkang force-pushed the how-to-documentation-for-shell-auto-complete branch from 75be9ca to f22abf3 Compare October 29, 2025 01:53
@saehejkang
Copy link
Contributor Author

Could you rework this commit so that your changes are rebased onto the head of main, instead of merging main into the head of your branch?

Done!

@jglogan jglogan merged commit 90a7165 into apple:main Oct 29, 2025
2 checks passed
@saehejkang saehejkang deleted the how-to-documentation-for-shell-auto-complete branch October 30, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: How-to documentation for container shell auto-complete.

2 participants