Fix: ElevenLabs API Key Not Persisting #6557

Abhijay007 · 2026-01-17T20:15:44Z

Closes: #6063

PR description

This PR fixes a bug where ElevenLabs API keys were not persisting in the desktop UI.

Changes:

Fixed key existence detection logic in both the settings hook and key input component
Improved UI styling for provider dropdown (overflow, width, text wrapping)

Type of Change

Bug fix

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Tested in Desktop UI with the whole functionality

Screenshots/Demos (for UX changes)

Before:

After:

Copilot

Pull request overview

This PR fixes a bug where ElevenLabs API keys were not persisting in the desktop UI. The core fix changes the key existence check from keyExists === true to keyExists !== null to properly detect stored keys.

Changes:

Fixed key existence detection logic in both the settings hook and key input component
Added masked value display (••••••••••••••••) for existing keys with focus/blur handling
Added 32-character minimum validation for ElevenLabs API keys
Improved UI styling for provider dropdown (overflow, width, text wrapping)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`ui/desktop/src/hooks/useDictationSettings.ts`	Fixed key existence check from `=== true` to `!== null`
`ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx`	Enhanced key persistence logic with masked display, validation, and better state handling
`ui/desktop/src/components/settings/dictation/VoiceDictationToggle.tsx`	Changed overflow from `hidden` to `visible` to prevent dropdown clipping
`ui/desktop/src/components/settings/dictation/ProviderSelector.tsx`	Improved dropdown styling with better width constraints and text formatting

Comments suppressed due to low confidence (1)

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx:52

The unmount effect saves the key without validation. If a user enters an invalid key (less than 32 characters) and the component unmounts before onBlur fires, the invalid key will be saved. Consider adding the same validation here or removing this unmount save since onBlur already handles saving.

  useEffect(() => {
    return () => {
      if (elevenLabsApiKeyRef.current && elevenLabsApiKeyRef.current !== '••••••••••••••••') {
        const keyToSave = elevenLabsApiKeyRef.current;
        if (keyToSave.trim()) {
          upsert(ELEVENLABS_API_KEY, keyToSave, true).catch((error) => {
            console.error('Error saving ElevenLabs API key on unmount:', error);
          });
        }
      }
    };

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

ui/desktop/src/hooks/useDictationSettings.ts

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

ui/desktop/src/hooks/dictationConstants.ts

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

ui/desktop/src/hooks/dictationConstants.ts:7

Assignment to variable isSecretKeyConfigured, which is declared constant.

export const isSecretKeyConfigured = (response: unknown): boolean =>

ui/desktop/src/components/settings/dictation/ProviderSelector.tsx

ui/desktop/src/hooks/dictationConstants.ts

Abhijay007 · 2026-01-23T19:11:21Z

Updated UX

cc : @lifeizhou-ap

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

lifeizhou-ap · 2026-01-23T23:05:56Z

Thank you @Abhijay007!

One thing I noticed the changes to optimise api call in the PR have been removed in this PR. Just wondering whether it is intentional or not.

Abhijay007 · 2026-01-24T16:52:39Z

Thank you @Abhijay007!

One thing I noticed the changes to optimise api call in the PR have been removed in this PR. Just wondering whether it is intentional or not.

oh yea, thanks @lifeizhou-ap for letting me know I made some mistakes while resolving merge conflicts and missed those changes 😅 , I updated em now

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

taniandjerry · 2026-01-26T18:48:19Z

It looks like comments were addressed, tagging @lifeizhou-ap and @zanesq again!

lifeizhou-ap · 2026-01-26T23:23:59Z

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

+      setElevenLabsApiKey('');
+      setValidationError('');
+      setIsEditing(false);
+      await loadKey();


Hi @Abhijay007 just curious why we hav to loadKey again in the upsert and remove? It added an extra call to the server side and it seems unnecessary? Shall we just update the cache and hasElevenLabsKey instead of the additional call?

it was mentioned here by copoilt : #6557 (comment) so I thought of implementing it

ui/desktop/src/hooks/useDictationSettings.ts

ui/desktop/package-lock.json

DOsinga · 2026-01-26T23:41:50Z

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx

@@ -1,5 +1,6 @@
-import { useState, useEffect, useRef } from 'react';
+import { useState, useEffect, useCallback } from 'react';


frankly, this whole module feels rather complicated. aren't we just setting an API key? there's validation code, but all it seems to do is check that the API key is set. or that the server failed but that's not very useful.

frankly, this whole module feels rather complicated. aren't we just setting an API key? there's validation code, but all it seems to do is check that the API key is set. or that the server failed but that's not very useful.

@lifeizhou-ap , @DOsinga should I consider this update in this PR or make another one for this refactor ?

Hi @Abhijay007,

Let's make another PR for this refactor.

ui/desktop/src/hooks/useDictationSettings.ts

lifeizhou-ap · 2026-01-26T23:50:38Z

they should both be constants, no?

Hi @DOsinga Yes. This is my fault because I did not extract openai as constant in another PR. I was intending to extract in the same PR, but openai is used in different contexts. It was not just used in dictation, it is also used in provider, and other etc. So I did not do it and thought about doing later.

Now I realised that I has overthought about the risk of extracting the openai constant. It is ok to only replace dictation related openai.

lifeizhou-ap · 2026-01-27T00:35:50Z

Hi @Abhijay007,

I also checked out your branch and it works well!

One feedback about the "Remove" button in UI.

This is your current UI
. With the "Remove" below the input text box, user may think it only removes the text in the input box instead of removing the api key.

I feel it will be clearer to user if we put next to "Update API Key". WDTY? (does not need to be in this PR. we can address this later if this makes sense)

Signed-off-by: Abhijay007 <[email protected]>

Abhijay007 · 2026-01-27T10:49:18Z

Hi @Abhijay007,

I also checked out your branch and it works well!

One feedback about the "Remove" button in UI.

This is your current UI . With the "Remove" below the input text box, user may think it only removes the text in the input box instead of removing the api key.

I feel it will be clearer to user if we put next to "Update API Key". WDTY? (does not need to be in this PR. we can address this later if this makes sense)

I think it's nice if we handle it in another PR

Signed-off-by: Abhijay007 <[email protected]>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

lifeizhou-ap · 2026-01-27T12:00:37Z

they should both be constants, no?

Hi @DOsinga Yes. This is my fault because I did not extract openai as constant in another PR. I was intending to extract in the same PR, but openai is used in different contexts. It was not just used in dictation, it is also used in provider, and other etc. So I did not do it and thought about doing later.

Now I realised that I has overthought about the risk of extracting the openai constant. It is ok to only replace dictation related openai.

Thank you @Abhijay007 to extract it!

…upport * origin/main: (79 commits) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718) fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) ... # Conflicts: # ui/desktop/src/hooks/useChatStream.ts

…ovider * 'main' of github.com:block/goose: fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700)

* 'main' of github.com:block/goose: Create default gooseignore file when missing (#6498) fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718)

Copilot AI review requested due to automatic review settings January 17, 2026 20:15

Copilot started reviewing on behalf of Abhijay007 January 17, 2026 20:16 View session

Abhijay007 requested a review from zanesq January 17, 2026 20:16

Copilot AI reviewed Jan 17, 2026

View reviewed changes

Abhijay007 requested a review from Copilot January 17, 2026 20:28

Copilot started reviewing on behalf of Abhijay007 January 17, 2026 20:29 View session

Copilot AI reviewed Jan 17, 2026

View reviewed changes

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx Outdated Show resolved Hide resolved

lifeizhou-ap reviewed Jan 23, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 23, 2026 18:22

Copilot started reviewing on behalf of Abhijay007 January 23, 2026 18:22 View session

Abhijay007 marked this pull request as draft January 23, 2026 18:23

Copilot AI reviewed Jan 23, 2026

View reviewed changes

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx Show resolved Hide resolved

ui/desktop/src/hooks/dictationConstants.ts Outdated Show resolved Hide resolved

Abhijay007 force-pushed the fix/ElevanLabsApi branch from f9881b6 to e8b6286 Compare January 23, 2026 18:37

Abhijay007 marked this pull request as ready for review January 23, 2026 18:41

Copilot AI review requested due to automatic review settings January 23, 2026 18:41

Copilot started reviewing on behalf of Abhijay007 January 23, 2026 18:42 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

ui/desktop/src/components/settings/dictation/ProviderSelector.tsx Show resolved Hide resolved

ui/desktop/src/hooks/dictationConstants.ts Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 23, 2026 19:10

Copilot started reviewing on behalf of Abhijay007 January 23, 2026 19:10 View session

Abhijay007 requested a review from lifeizhou-ap January 23, 2026 19:11

Copilot AI reviewed Jan 23, 2026

View reviewed changes

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx Show resolved Hide resolved

Abhijay007 force-pushed the fix/ElevanLabsApi branch from 7fec68f to a90144a Compare January 24, 2026 16:51

Abhijay007 force-pushed the fix/ElevanLabsApi branch from a90144a to af114d5 Compare January 26, 2026 18:19

Copilot AI review requested due to automatic review settings January 26, 2026 18:19

Copilot started reviewing on behalf of Abhijay007 January 26, 2026 18:19 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

ui/desktop/src/components/settings/dictation/ElevenLabsKeyInput.tsx Show resolved Hide resolved

Whitewolf111 mentioned this pull request Jan 26, 2026

It looks like comments were addressed, tagging @lifeizhou-ap and @zanesq again! #6720

Closed

lifeizhou-ap reviewed Jan 26, 2026

View reviewed changes

ui/desktop/src/hooks/useDictationSettings.ts Outdated Show resolved Hide resolved

DOsinga approved these changes Jan 26, 2026

View reviewed changes

Abhijay007 added 7 commits January 27, 2026 10:35

Fix: ElevenLabs API Key Not Persisting

54fb99a

Signed-off-by: Abhijay007 <[email protected]>

fix: updated error validations and other things

f259ebe

Signed-off-by: Abhijay007 <[email protected]>

refactor: addressed requested changes and updated UX

2f7f8a5

Signed-off-by: Abhijay007 <[email protected]>

refactor: removed duplicated code due to merge conflicts

f27d619

Signed-off-by: Abhijay007 <[email protected]>

refactor : Restored import of DICTATION_PROVIDER_ELEVENLABS

7952b5c

Signed-off-by: Abhijay007 <[email protected]>

refactor: reverted API optimization

6a28a3d

Signed-off-by: Abhijay007 <[email protected]>

refactor: added await await loadKey in handleRemove

544d452

Signed-off-by: Abhijay007 <[email protected]>

refactor: addressed changed and added constants

e877fe2

Signed-off-by: Abhijay007 <[email protected]>

Abhijay007 force-pushed the fix/ElevanLabsApi branch from af114d5 to e877fe2 Compare January 27, 2026 10:51

update: package.json to match main

0659945

Signed-off-by: Abhijay007 <[email protected]>

Copilot AI review requested due to automatic review settings January 27, 2026 11:02

Copilot started reviewing on behalf of Abhijay007 January 27, 2026 11:03 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

lifeizhou-ap approved these changes Jan 27, 2026

View reviewed changes

Abhijay007 merged commit 2a41f5d into block:main Jan 27, 2026
23 checks passed

Abhijay007 mentioned this pull request Jan 28, 2026

refactor: updated elevenLabs API module and remove button UX #6781

Open

2 tasks

This was referenced Jan 29, 2026

chore(release): release version 1.22.0 (minor) #6812

Closed

chore(release): release version 1.22.0 (minor) #6813

Open

		@@ -1,5 +1,6 @@
		import { useState, useEffect, useRef } from 'react';
		import { useState, useEffect, useCallback } from 'react';

Fix: ElevenLabs API Key Not Persisting #6557

Fix: ElevenLabs API Key Not Persisting #6557

Uh oh!

Conversation

Abhijay007 commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description

Changes:

Type of Change

AI Assistance

Testing

Screenshots/Demos (for UX changes)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Abhijay007 commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

lifeizhou-ap commented Jan 23, 2026

Uh oh!

Abhijay007 commented Jan 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

taniandjerry commented Jan 26, 2026

Uh oh!

lifeizhou-ap Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Abhijay007 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DOsinga Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Abhijay007 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lifeizhou-ap commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Abhijay007 commented Jan 17, 2026 •

edited

Loading

lifeizhou-ap commented Jan 26, 2026 •

edited

Loading

lifeizhou-ap commented Jan 27, 2026 •

edited

Loading