Use Vec to implement the Events iterators#117
Conversation
Using `vec::IntoIter` is much simpler than a deeply nested `Chain`, compiling faster and avoiding the deeper recursion limit reported in [rust#71359](rust-lang/rust#71359).
|
In the test I've crudely sketched up, this behaves equivalently to the #115 version (which solves the same issue but just ups the recursion depth). A rough comparison indicates equal or slightly-better performance of this over #115, by I have zero trust in the test setup as I don't really know what I'm benchmarking or what for. I really can't say anything about the suitability of the Vec allocation, as I don't yet use the parts of typed-html that deal with exotic allocators (like dodrio on bumpalo) where it may or may not be relevant. |
|
The Vec shouldn't have an impact on Dodrio, it couldn't be allocated using a bump allocator in any case. Anyway, good work, merging 👍 |
|
@bodil could you publish a new release, so we might feel safer in closing that Rust issue? 🙂 |
|
Because there is no release yet, I depended directly on the latest git commit in my Cargo.toml like this:
and my broken compile is fixed! To feed the search engines, the compile error I had before was:
|
This contains a fix for that now allows release builds to be made. bodil/typed-html#117
|
@bodil you should release this fix to crates.io |
Using
vec::IntoIteris much simpler than a deeply nestedChain,compiling faster and avoiding the deeper recursion limit reported in
rust#71359.