feat: Add --id option to connect to existing remote agents via tunnel #7999
+300
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="extensions/cli/src/commands/remote.ts">
<violation number="1" location="extensions/cli/src/commands/remote.ts:253">
Rule violated: **Don't use console.log**
Route this output through the logger to comply with the "Don't use console.log" rule and keep logging consistent.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| ); | ||
| await gracefulExit(1); | ||
| function printStartJson(payload: Record<string, unknown>) { | ||
| console.log(JSON.stringify(payload)); |
Contributor
There was a problem hiding this comment.
Rule violated: Don't use console.log
Route this output through the logger to comply with the "Don't use console.log" rule and keep logging consistent.
Prompt for AI agents
Address the following comment on extensions/cli/src/commands/remote.ts at line 253:
<comment>Route this output through the logger to comply with the "Don't use console.log" rule and keep logging consistent.</comment>
<file context>
@@ -9,155 +9,258 @@ import { getRepoUrl } from "../util/git.js";
- );
- await gracefulExit(1);
+function printStartJson(payload: Record<string, unknown>) {
+ console.log(JSON.stringify(payload));
+}
+
</file context>
github-actions
bot
added
the
tier 2
Contributor
Author
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a --id option to connect to an existing remote agent via a tunnel, with improved flow and error handling for the remote command. Also updates start-mode JSON output and tests.
New Features
Refactors