-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: add remove rule button #9576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 13 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="core/core.ts">
<violation number="1" location="core/core.ts:435">
P1: `config/deleteRule` deletes arbitrary caller-provided paths without validating they are rule files or within allowed directories, enabling arbitrary file deletion</violation>
</file>
<file name="extensions/vscode/src/VsCodeIde.ts">
<violation number="1" location="extensions/vscode/src/VsCodeIde.ts:305">
P1: removeFile deletes arbitrary URIs with no scheme or workspace validation, enabling arbitrary file deletion via protocol input</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
sestinj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me, though take a look at Cubic's comments
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add a button to remove the rule file, instead of going to the file location and then deleting it.
Also adds a protocol in vscode and jetbrains to remove a particular file by its uri.
closes #9426
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
feat.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks:▶️ 2 queued — View all
Summary by cubic
Add a Delete Rule button in the Rules page so users can remove rule files without leaving the app. Adds a cross-IDE delete protocol and reloads config after deletion.
Written for commit 904357d. Summary will update on new commits.