Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Jan 16, 2026

Description

Add a button to remove the rule file, instead of going to the file location and then deleting it.

Also adds a protocol in vscode and jetbrains to remove a particular file by its uri.

closes #9426

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

feat.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Continue Tasks: ▶️ 2 queued — View all


Summary by cubic

Add a Delete Rule button in the Rules page so users can remove rule files without leaving the app. Adds a cross-IDE delete protocol and reloads config after deletion.

  • New Features
    • UI: Trash button on rule cards (non-default rules) with a confirmation dialog.
    • Core: New "config/deleteRule" message deletes the file, invalidates the dir cache, and reloads the config.
    • Protocol: Added IDE removeFile RPC and pass-through wiring.
    • IDEs: Implemented removeFile in VS Code and IntelliJ.

Written for commit 904357d. Summary will update on new commits.

@uinstinct uinstinct requested a review from a team as a code owner January 16, 2026 10:27
@uinstinct uinstinct requested review from RomneyDa and removed request for a team January 16, 2026 10:27
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 16, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 13 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="core/core.ts">

<violation number="1" location="core/core.ts:435">
P1: `config/deleteRule` deletes arbitrary caller-provided paths without validating they are rule files or within allowed directories, enabling arbitrary file deletion</violation>
</file>

<file name="extensions/vscode/src/VsCodeIde.ts">

<violation number="1" location="extensions/vscode/src/VsCodeIde.ts:305">
P1: removeFile deletes arbitrary URIs with no scheme or workspace validation, enabling arbitrary file deletion via protocol input</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

sestinj
sestinj previously approved these changes Jan 16, 2026
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, though take a look at Cubic's comments

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jan 16, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2026
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 19, 2026
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@RomneyDa RomneyDa merged commit 1a84843 into continuedev:main Jan 22, 2026
53 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jan 22, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2026
@sestinj
Copy link
Contributor

sestinj commented Jan 22, 2026

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uinstinct uinstinct deleted the remove-rule-button branch January 23, 2026 04:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants