-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Refactor imports. #9828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor imports. #9828
Conversation
…File reads weren't working, but now are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/openai-adapters/src/apis/AskSage.ts">
<violation number="1" location="packages/openai-adapters/src/apis/AskSage.ts:431">
P2: Streaming finish_reason is derived from raw tool call count, so it can report "tool_calls" even when all tool calls were filtered out and none were emitted.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cubic comment seems valid
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-mcgraw-askSage noticed the title mentions a fix for CLI file reads, was that intentional?
…en it should have been determined by validToolCalls in case all of the raw tool calls were filtered out because of malformed responses
@RomneyDa Thanks for the catch on the rawToolCalls! In regards to CLI file reads, yes. When testing the updates, I tried reading files, "tell me about this file @", and i was getting an error. A bug got introduced in my last PR with file reads, so needed that fixed. edit 1: My bad, I'm looking back at the changes and see everything is related to the extensions and none to core. I realized the problem was something with my debugger config, so no need to worry about that. I'll fix that title now. |
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Refactor some interface imports, and fixed a bug in the CLI tooling. File reads weren't working, but now are.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Example of file reads in the CLI tool.
Tests
NA
Continue Tasks:▶️ 3 queued — View all
Summary by cubic
Fixed CLI file reading and standardized AskSage type definitions across core and openai-adapters to reduce errors and improve compatibility.
Bug Fixes
Refactors
Written for commit 63a8f8c. Summary will update on new commits.