Do not filter out current user from permissions list #3688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Sep 30, 2025
Collaborator
14 failing tests:
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Oct 1, 2025
Contributor
Author
|
Unfortunately it appears that we still to have to filter it out due to this Otherwise our default template sends permissions with 2 different levels for the current user (CAN_MANAGE and IS_OWNER) leading to the failure on GCP https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/18136388471/job/51616200179 |
auto-merge was automatically disabled
October 1, 2025 13:47
Pull request was closed
denik
added a commit
that referenced
this pull request
Oct 20, 2025
## Changes Instead of removing current user from permissions and relying on terraform to add it back, we'll instead add IS_OWNER/CAN_MANAGE ourselves. Previous attempt to remove this mutator completely #3688 failed because backend complains about "ambiguous" permissions when both CAN_MANAGE and IS_OWNER are present. Thus we do additional transformation here: we upgrade CAN_MANAGE to IS_OWNER if we can. Don't apply this logic to secret scopes resource as it's not implemented via databricks_permissions resource in terraform and does not have IS_OWNER/CAN_MANAGE insertion logic. This means we no longer filter out current user permissions from secret scopes resources. ## Why - Enables direct implementation which will not do any transformations, just use whatever in the config. With this PR, the request payload will match terraform's. - Final permissions visible in 'bundle validate -o json'. ## Tests #3781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It removes the
FilterCurrentUsermutator.Why
This mutator was introduced to avoid Terraform-related issues regarding setting the permission for the user who deploys the resources (current user). Since then Terraform issue was resolved, and we don't need to filter out current users from the permission list anymore
databricks/terraform-provider-databricks#3956
Tests
Existing tests pass + manually checked that deploying with different identities for the owner works