Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: cdfd3d6
9 interesting tests: 7 KNOWN, 2 SKIP
Top 28 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/migrate-plan-check
branch
from
b4a882c to
c697d2a
Compare
andrewnester
approved these changes
Dec 8, 2025
cmd/bundle/deployment/migrate.go
Outdated
| if errors.As(err, &exitErr) { | ||
| msg = fmt.Sprintf("exit code %d", exitErr.ExitCode()) | ||
| } else { | ||
| msg = exitErr.String() |
Contributor
There was a problem hiding this comment.
Shouldn't it be err.String() instead?
Collaborator
|
Commit: a9ba5c0
14 interesting tests: 7 KNOWN, 5 flaky, 1 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
Follow up to #4088, we need to pass "-p profile" as well.
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Dec 10, 2025
## Release v0.280.0 ### Bundles * Fixed changing the source for the SQL task from GIT to WORKSPACE ([#4114](#4114)) * `bundle deployment migrate` will now run a plan before migration to check if deployment was done ([#4088](#4088)) * engine/direct: Increase "serial" in state file after every deployment ([#4115](#4115)) ### Dependency updates * Upgrade Go SDK to 0.93.0 ([#4112](#4112)) * Bump Go toolchain to 1.25.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since we ask to do the deploy before the migration, running plan ensures people don't forget to do that.