Skip to content

Recommend to use c++filt#755

Merged
bartlomieju merged 1 commit intodenoland:mainfrom
kubo39:patch-1
Jul 21, 2021
Merged

Recommend to use c++filt#755
bartlomieju merged 1 commit intodenoland:mainfrom
kubo39:patch-1

Conversation

@kubo39
Copy link
Contributor

@kubo39 kubo39 commented Jun 27, 2021

Since 2016-11-16 c++filt 1 recognizes rust legacy demangling and will supports newer one(v0 name mangling) 2 3, so it would be better choice.

Since 2016-11-16 c++filt [1] recognizes rust legacy demangling and will
supports newer one(v0 name mangling) [2] [3], so it would be better choice.

[1]: https://sourceware.org/binutils/docs/binutils/c_002b_002bfilt.html
[2]: rust-lang/rfcs#2603
[3]: https://sourceware.org/bugzilla/show_bug.cgi?id=27194
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kubo39

@bartlomieju bartlomieju merged commit 107cef0 into denoland:main Jul 21, 2021
@kubo39 kubo39 deleted the patch-1 branch July 21, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants