Add --additional-features option#171
Merged
stuartleeks merged 2 commits intodevcontainers:mainfrom Oct 3, 2022
Merged
Conversation
stuartleeks
force-pushed
the
sl/additional-features
branch
3 times, most recently
from
b8b3d6d to
3d0317e
Compare
stuartleeks
changed the title
stuartleeks
force-pushed
the
sl/additional-features
branch
from
3d0317e to
0e006ea
Compare
chrmarti
requested changes
Oct 3, 2022
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Looks great. Left two comments for change / discussion. Thanks!
stuartleeks
force-pushed
the
sl/additional-features
branch
2 times, most recently
from
fd35f1a to
7f2c89d
Compare
Collaborator
Author
|
@chrmarti - I've pushed an update that hopefully addresses your feedback |
Contributor
@stuartleeks Still seeing the additional clause in |
Make additionalFeatures parameter required Avoid requerying features for existing container
stuartleeks
force-pushed
the
sl/additional-features
branch
from
7f2c89d to
70adff6
Compare
Collaborator
Author
|
Oops! I'm not sure what happened there - sorry! I have reapplied the change to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work to enable additional features to be specified via the CLI