GPU requirement and auto-detect NVIDIA extensions#173
GPU requirement and auto-detect NVIDIA extensions#173chrmarti merged 9 commits intodevcontainers:mainfrom
Conversation
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have left a comment.
chris-major-improbable
force-pushed
the
chrism/gpu-requriements
branch
from
abece2b to
b012c96
Compare
chris-major-improbable
force-pushed
the
chrism/gpu-requriements
branch
2 times, most recently
from
5bf01c3 to
5af8294
Compare
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for the update! I have added a few more comments.
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Looks good, left a few more comments. Thanks!
chris-major-improbable
force-pushed
the
chrism/gpu-requriements
branch
2 times, most recently
from
6dca834 to
dfc50d4
Compare
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
LGTM! (Looping in our partner team for cross-review. Will merge after that. Thanks!)
|
Hey @chrmarti just seen a lot of test failures on the CI - and slightly at a loss to understand what they mean and why they are failing. I'm happy to take a look, but I'm not sure what the difference between |
to support merging GPU requirements
chris-major-improbable
force-pushed
the
chrism/gpu-requriements
branch
from
aa7ef00 to
6772741
Compare
|
I've taken a bit of a closer look, and rebased onto the latest main - and I see the same failures running the tests locally, so I don't think this is a regression from this PR. |
|
@chris-major-improbable I have merged in the main branch and fixed an issue with the PR I found when looking into the test failures. Please check the above comment from the CLA bot, we must have added that after you submitted the PR. Thanks! |
|
@microsoft-github-policy-service agree [company="{Improbable Worlds Ltd}"] |
|
@microsoft-github-policy-service agree company="{Improbable Worlds Ltd}" |
|
@microsoft-github-policy-service agree company="Improbable Worlds Ltd" |
|
Thanks for that - looks good to me. |
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
LGTM! (Will get a second review now.) Thanks!
joshspicer
left a comment
joshspicer
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution.
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Looks great. Thanks for the contribution! ✨
4 participants
This PR builds upon the proposal in devcontainers/spec#82
When launching a devcontainer requesting GPUs it also detects the presence of NVIDIA docker extensions, and adds the
--gpus allflag.This means that the same devcontainer can be used by developments that don't all have GPU's.
It also does the equivalent for docker-compose scripts, adding the GPU access to the service specified in the
devcontainer.jsonfile