-
Notifications
You must be signed in to change notification settings - Fork 67
fix: common PVC cleanup job to be assigned to a correct node #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
/retest |
Co-authored-by: Rohan Kumar <[email protected]> Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akurinnoy, dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@akurinnoy I've tested on a single node and multi node cluster, I just have one small suggestion |
|
New changes are detected. LGTM label has been removed. |
Co-authored-by: David Kwon <[email protected]> Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
Thank you @akurinnoy , please squash and merge |
What does this PR do?
This pull request enhances the common PVC cleanup job by adding node affinity rule.
This change modifies the cleanup job creation logic to:
volume.kubernetes.io/selected-nodeannotation from the common PVC associated with the DevWorkspace.requiredDuringSchedulingIgnoredDuringExecutionnode affinity rule to the cleanup job's pod spec, targeting the specified node.This ensures that the cleanup job pod runs on the same node as the volume. If the annotation is not present, no node affinity is added.
What issues does this PR fix or reference?
resolves #1269
Is it tested? How?
volume.kubernetes.io/selected-nodeannotation. Note the node name specified in the annotation value.nodeSelectorTermstarget the node name noted in step 2 via thekubernetes.io/hostnamekey.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che