Skip to content

fix: collect canister env vars in BTreeMap#4393

Merged
viviveevee merged 3 commits into
masterfrom
luca/test-cookie
Sep 30, 2025
Merged

fix: collect canister env vars in BTreeMap#4393
viviveevee merged 3 commits into
masterfrom
luca/test-cookie

Conversation

@ilbertt
Copy link
Copy Markdown
Contributor

@ilbertt ilbertt commented Sep 26, 2025

Description

Switch to using BTreeMap instead of HashMap for canister env variables, to ensure consistent ordering.

As a follow-up of #4387, adds unit tests too.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ilbertt ilbertt requested a review from a team as a code owner September 26, 2025 15:47
@ilbertt ilbertt changed the title test: unit test ic_env cookie fix: collect canister env vars in BTreeMap Sep 27, 2025
Comment thread src/canisters/frontend/ic-certified-assets/src/tests.rs Outdated
Comment thread src/canisters/frontend/ic-certified-assets/src/tests.rs
Comment thread src/canisters/frontend/ic-certified-assets/src/tests.rs
@viviveevee viviveevee merged commit 12b1492 into master Sep 30, 2025
223 of 225 checks passed
@viviveevee viviveevee deleted the luca/test-cookie branch September 30, 2025 12:19
ilbertt added a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants