Expand $EDITOR in the TUI #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
reviewed
Jan 7, 2026
pkg/tui/page/chat/chat.go
Outdated
| "zed": "Zed", | ||
| } | ||
|
|
||
| if displayName, ok := editorNames[baseName]; ok { |
Member
There was a problem hiding this comment.
It would be better to check if it starts with, an $EDITOR coud be code --wait for example
jeanlaurent
force-pushed
the
editor-name
branch
from
84bbe25 to
8ff630b
Compare
dgageot
requested changes
Jan 7, 2026
~/english_corrector.yaml
Outdated
| @@ -0,0 +1,50 @@ | |||
| version: 2 | |||
pkg/tui/page/chat/chat_test.go
Outdated
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Set test env | ||
| t.Setenv("VISUAL", "") |
Member
There was a problem hiding this comment.
Can you avoid setting env variables in tests? It prevents run running tests in parallel
pkg/tui/page/chat/chat_test.go
Outdated
| { | ||
| name: "Empty", | ||
| envValue: "", | ||
| want: "$EDITOR", |
Member
There was a problem hiding this comment.
For me, $EDITOR means vim. Probably a default somewhere. Do you handle that?
Contributor
|
One thing we could add here, or do in a subsequent PR, is removing the footer option altogether for those users that don't have $EDITOR set, since it just flashes the screen atm |
Signed-off-by: Jean-Laurent de Morlhon <[email protected]>
jeanlaurent
force-pushed
the
editor-name
branch
from
8ff630b to
885c20e
Compare
dgageot
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand $EDITOR to actual editor name in TUI help text
The TUI help footer now displays the actual configured editor name instead of the literal
string "$EDITOR".
Before: Ctrl+g edit in $EDITOR
After: Ctrl+g edit in VSCode (or Vim, Neovim, Cursor, etc.)
The implementation:
so moving from
to