Fix data race in telemetry package #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper synchronization for global telemetry variables and Client.version field to prevent races between: - SetGlobalTelemetryVersion writing globalTelemetryVersion - EnsureGlobalTelemetryInitialized reading globalTelemetryVersion - SetGlobalTelemetryVersion writing Client.version - performHTTPRequest and createEvent reading Client.version Changes: - Add globalMu RWMutex to protect globalTelemetryVersion and globalTelemetryDebugMode - Add setVersion/getVersion methods to Client for thread-safe version access - Pass version as parameter to performHTTPRequest to avoid deadlock Assisted-By: cagent
rumpl
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper synchronization for global telemetry variables and Client.version field to prevent races between:
Changes:
Assisted-By: cagent