Update jsonschema #1389
Merged
Update jsonschema #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests only test provider schemas so no need for them to be in tools Signed-off-by: Djordje Lukic <[email protected]>
Signed-off-by: Djordje Lukic <[email protected]>
With this update jsonschema decided that slices and such have a type of [null, string], which is correct in golang world, but it breaks Gemini so we need to tweak and remove all the array-defined types and take only the type itself. Signed-off-by: Djordje Lukic <[email protected]>
krissetto
approved these changes
Jan 16, 2026
| out := cagentExec(t, "testdata/fs_tools.yaml", "--model=mistral/mistral-small", "How many files in testdata/working_dir? Only output the number.") | ||
|
|
||
| require.Equal(t, "\n--- Agent: root ---\n\nCalling list_directory(path: \"testdata/working_dir\")\n\nlist_directory response → \"FILE README.me\\n\"\n1", out) | ||
| // NOTE: If you look at the LLM response, Mistral says it sees 2 files, yours truly got tired of re-running this test to get it to say "1". |
| } | ||
|
|
||
| // The Response API requires every parameter to be required | ||
| parameters = makeAllRequired(parameters) |
Contributor
There was a problem hiding this comment.
is this safe to remove? wasn't expecting this change here
Member
Author
There was a problem hiding this comment.
It wasn't removed, I moved these to ConvertParametersToSchema so both Responses and Chat APIs will get the same treatment.
Yes I have tested this, our e2e tests still work and I tested with the responses api too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update jsonschema decided that slices and such have a type of [null, string], which is correct in golang world, but it breaks Gemini so we need to tweak and remove all the array defined types and take only the type itself.
Also moved the code a bit and unified the way we convert parameters in openai