Faster markdown tables #1451
Merged
Faster markdown tables #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use lipgloss.Width() instead of runewidth.StringWidth() when calculating table column widths and padding. runewidth.StringWidth() counts ANSI escape sequences as characters, causing misaligned columns when cells contain inline markdown (bold, italic, code) that renders to ANSI codes. Assisted-By: cagent
Assisted-By: cagent
- Introduce tableCell struct to pre-render cells during parsing, avoiding duplicate renderInline() calls - Replace strings.Split with manual parsing in parseAndRenderTableRow to avoid slice allocations - Write directly to output buffer instead of intermediate builders - Pre-calculate separator line once and reuse it - Replace strings.Repeat for padding with byte-by-byte writes - Use strings.SplitSeq for blockquote line iteration - Use max() builtin for content width calculation Benchmark results show ~36% faster execution, 44% less memory usage, and 68% fewer allocations for table rendering. Assisted-By: cagent
rumpl
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.