feat : Add storageAccessMode to PVC che cluster types

[rohanKanojia]

What does this PR do?

This is a follow-up PR to devfile/devworkspace-operator#1430

• Update github.com/devfile/devworkspace-operator dependency to v0.35.0
• Add storageAccessMode to PVC che cluster types
• Set StorageAccessMode while updating WorkspaceConfig during reconcile

Signed-off-by: Rohan Kumar [email protected]

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It's related to this PR devfile/devworkspace-operator#1430

How to test this PR?

1. Prepare a patch file if needed:

cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec:
  devEnvironments:
    storage:
      perUserStrategyPvcConfig:
        storageAccessMode:
        - ReadWriteMany
EOF

2. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

3. Verify that the devworkspace-config DWOC in the eclipse-che namespace has the following fields:

kubectl get dwoc devworkspace-config -neclipse-che -ojsonpath='{.config.workspace.storageAccessMode}'
["ReadWriteMany"]

5. In the Che CR, spec.devEnvironments.storage.perUserStrategyPvcConfig.storageAccessMode to [ "ReadOnlyMany" ]. Verify that the DWOC has the same fields:

kubectl get dwoc devworkspace-config -neclipse-che -ojsonpath='{.config.workspace.storageAccessMode}'
["ReadOnlyMany"]

5. In the Che CR, remove the spec.devEnvironments.storage.perUserStrategyPvcConfig.storageAccessMode field. Verify that the storageAccessMode has been removed from the DWOC:

# Should return blank output
kubectl get dwoc devworkspace-config -neclipse-che -ojsonpath='{.config.workspace.storageAccessMode}'

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Development resource are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rohanKanojia]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia, tolusha

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tolusha]

@rohanKanojia
Please merge

[rohanKanojia]

@tolusha : Sorry, I don't have merge access.

Shall we wait for @dkwon17 's approval as well?

[dkwon17]

The default ReadWriteOnce is not being used in this case,

For example, if I set:

    storage:
      perUserStrategyPvcConfig:
        storageAccessMode:
          - ReadWriteMany
      pvcStrategy: per-user

And then if I remove perUserStrategyPvcConfig:

  storage:
    pvcStrategy: per-user

the DWOC still has ReadWriteMany:

apiVersion: controller.devfile.io/v1alpha1
config:
  workspace:
    storageAccessMode:
      - ReadWriteMany

[dkwon17]

storageClass and claimSize has the same behaviour where the defaults aren't applied:

che-operator/pkg/deploy/dev-workspace-config/dev_workspace_config.go

Line 165 in e2c3bf9

if pvc.StorageClass != "" {

che-operator/pkg/deploy/dev-workspace-config/dev_workspace_config.go

Line 169 in e2c3bf9

if pvc.ClaimSize != "" {

[rohanKanojia]

I've created this issue for addressing it eclipse-che/che#23502